Ios deployment #135
Closed
Ios deployment #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 2, 2023 11:19
|
@freed0m266 your pull request is missing a changelog! |
|
Hi, what is the motivation here, I don't see a single reason here for increasing deployment target to 14.0. 12.0 is acceptable as that is the lowest supported by Xcode 15.x And definitely if bumping deployment targets, don't forget about SPM and Cocoapods. |
|
Hi 👋 My motivation was just a warning in projects where I'm using ACKategories, that's all. 🙂 |
|
Well then iOS 12 is the way to go as it is the lowest supported version in Xcode 15 and we also need iOS for some of our projects. |
|
@freed0m266 Hey, you can just create a fork for this purpose. |
|
In #137 I bumped deployment target to iOS 12, so this should be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist